XWIKI-22579: Livedata filter selectize input for lists does not have a label #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a label * Added a way to retrieve the aria-label of the input to complete the control-input
mflorea
approved these changes
Dec 9, 2024
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
…src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22579
Changes
Description
Clarifications
Screenshots & Video
Here, we look at the liveData from the menu application, which caused a lot of fails in test suites:
Before the changes proposed in this PR:
We can see that the LD List filter control-input does not have any text alternative.
After the changes proposed in this PR:
We can see that the text alternative is retrieve from the augmented input.
Additionally, a Axe core analysis of the page above returned 0 violations of WCAG (after the PR was applied).
Executed Tests
First, I built the changes locally with
mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Pquality. Then I started a test suite where some of those Livedata List filters prompted errors on the CI. Namely,mvn clean install -f xwiki-platform-core/xwiki-platform-release/xwiki-platform-release-test/xwiki-platform-release-test-docker/ -Pdocker -Dxwiki.test.ui.wcag=true. The wcagWarning file generated from these tests still reported the errors from https://jira.xwiki.org/browse/XWIKI-22580, but none from XWIKI-22579.I did not test all the other modules where the errors at the origin of this ticket happened, but from this limited testing I can assess that this PR does not create new WCAG issues and passes quality tests.
Expected merging strategy